Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paa improve #3985

Merged
merged 7 commits into from
Oct 25, 2020
Merged

Paa improve #3985

merged 7 commits into from
Oct 25, 2020

Conversation

Johnson-Wang
Copy link
Collaborator

@Johnson-Wang Johnson-Wang commented Oct 23, 2020

Continue over #3803
Multiple choices of covariance_type are now supported.

Changing the covariance_type from 'full' to 'diag' does improve the training speed and yield the same performance. Yet the acceleration rate is around 10%-20%.

@CLAassistant
Copy link

CLAassistant commented Oct 23, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ rydenisbak
✅ Johnson-Wang
❌ d.rybalchenko


d.rybalchenko seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #3985 into master will increase coverage by 0.12%.
The diff coverage is 64.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3985      +/-   ##
==========================================
+ Coverage   62.17%   62.30%   +0.12%     
==========================================
  Files         221      221              
  Lines       16314    16321       +7     
  Branches     2759     2762       +3     
==========================================
+ Hits        10144    10169      +25     
+ Misses       5678     5657      -21     
- Partials      492      495       +3     
Flag Coverage Δ
#unittests 62.30% <64.28%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/models/dense_heads/paa_head.py 89.79% <64.28%> (-1.81%) ⬇️
mmdet/models/roi_heads/mask_heads/maskiou_head.py 100.00% <0.00%> (+5.37%) ⬆️
mmdet/models/roi_heads/mask_scoring_roi_head.py 87.50% <0.00%> (+32.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d59215...2740161. Read the comment docs.

@Johnson-Wang Johnson-Wang added the enhancement New feature or request label Oct 23, 2020
@hellock hellock merged commit 95c05de into open-mmlab:master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants