Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

masks from (n,h,w) to [(h,w),...,(h,w)] #4032

Merged
merged 6 commits into from
Nov 19, 2020
Merged

masks from (n,h,w) to [(h,w),...,(h,w)] #4032

merged 6 commits into from
Nov 19, 2020

Conversation

howardchina
Copy link
Contributor

@CLAassistant
Copy link

CLAassistant commented Oct 30, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #4032 (b4633be) into master (b515fb9) will increase coverage by 0.07%.
The diff coverage is 53.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4032      +/-   ##
==========================================
+ Coverage   61.78%   61.86%   +0.07%     
==========================================
  Files         224      225       +1     
  Lines       16632    16672      +40     
  Branches     2810     2825      +15     
==========================================
+ Hits        10276    10314      +38     
+ Misses       5859     5853       -6     
- Partials      497      505       +8     
Flag Coverage Δ
unittests 61.82% <53.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/apis/inference.py 20.48% <0.00%> (-1.04%) ⬇️
mmdet/apis/test.py 13.51% <0.00%> (-0.13%) ⬇️
mmdet/core/anchor/anchor_generator.py 78.98% <ø> (ø)
...mdet/core/bbox/iou_calculators/iou2d_calculator.py 96.77% <ø> (ø)
mmdet/models/dense_heads/anchor_head.py 85.84% <ø> (ø)
mmdet/models/dense_heads/atss_head.py 27.94% <ø> (-0.02%) ⬇️
mmdet/models/dense_heads/gfl_head.py 27.35% <ø> (-0.04%) ⬇️
mmdet/models/dense_heads/vfnet_head.py 31.48% <ø> (+0.07%) ⬆️
mmdet/models/dense_heads/yolo_head.py 34.04% <0.00%> (-0.19%) ⬇️
mmdet/models/losses/focal_loss.py 43.90% <0.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b515fb9...dd615e0. Read the comment docs.

@hellock hellock requested a review from yhcao6 October 31, 2020 13:14
bitmapmasks = results['masks'].masks
for i in range(bitmapmasks.shape[0]):
masks_list += [bitmapmasks[i,:,:]]
results['masks'] = masks_list
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be simplified by np.vsplit

@hellock
Copy link
Member

hellock commented Nov 4, 2020

Task linked: CU-4zxm6k [Review] MMdet #4032

@yhcao6
Copy link
Collaborator

yhcao6 commented Nov 19, 2020

@howardchina, please sign CLAassistant, then we can merge.

@howardchina
Copy link
Contributor Author

CLAassistant is signed already.

@ZwwWayne ZwwWayne merged commit 1cbe18b into open-mmlab:master Nov 19, 2020
@Adblu
Copy link

Adblu commented Dec 3, 2020

Thanks for the fantastic work regarding new release !
I have 1 question regarding TODO in transforms.py , my training crushes when I'm using albu augmentation. I have found a bug fix, however its not elegant and brings lot of problems.
Are you planning to resolve it in future @howardchina @ZwwWayne @yhcao6 ?

@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Dec 5, 2020

Please @yhcao6 have a look for that.

@Adblu
Copy link

Adblu commented Jan 4, 2021

@ZwwWayne @yhcao6 Is there any update on the issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants