Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild hungarian assigner #4259

Merged
merged 15 commits into from
Dec 23, 2020

Conversation

kellenf
Copy link
Contributor

@kellenf kellenf commented Dec 9, 2020

add focal_loss in hungarian assigner and rebuild its structure

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


fangkairen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

mmdet/core/bbox/match_costers/match_cost.py Outdated Show resolved Hide resolved
mmdet/core/bbox/match_costers/match_cost.py Outdated Show resolved Hide resolved
mmdet/core/bbox/match_costers/match_cost.py Outdated Show resolved Hide resolved
mmdet/core/bbox/match_costers/match_cost.py Outdated Show resolved Hide resolved
mmdet/core/bbox/match_costers/match_cost.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@kellenf kellenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

mmdet/core/bbox/match_costers/match_cost.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@kellenf kellenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed match_costers -> match_costs

@ZwwWayne
Copy link
Collaborator

Please merge master to resolve conflicts.

@kellenf
Copy link
Contributor Author

kellenf commented Dec 22, 2020

merged master

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #4259 (3b7cf23) into master (23ded99) will increase coverage by 0.02%.
The diff coverage is 95.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4259      +/-   ##
==========================================
+ Coverage   61.79%   61.81%   +0.02%     
==========================================
  Files         237      240       +3     
  Lines       18218    18267      +49     
  Branches     3052     3058       +6     
==========================================
+ Hits        11258    11292      +34     
- Misses       6415     6427      +12     
- Partials      545      548       +3     
Flag Coverage Δ
unittests 61.78% <95.52%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/core/bbox/match_costs/match_cost.py 93.61% <93.61%> (ø)
mmdet/core/bbox/assigners/hungarian_assigner.py 88.37% <100.00%> (-1.22%) ⬇️
mmdet/core/bbox/match_costs/__init__.py 100.00% <100.00%> (ø)
mmdet/core/bbox/match_costs/builder.py 100.00% <100.00%> (ø)
mmdet/models/dense_heads/transformer_head.py 96.39% <100.00%> (ø)
mmdet/models/roi_heads/mask_scoring_roi_head.py 55.35% <0.00%> (-32.15%) ⬇️
mmdet/models/roi_heads/mask_heads/maskiou_head.py 94.62% <0.00%> (-5.38%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23ded99...3b7cf23. Read the comment docs.

Copy link
Contributor Author

@kellenf kellenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

# Conflicts:
#	mmdet/core/bbox/assigners/hungarian_assigner.py
@ZwwWayne ZwwWayne merged commit 0c84b65 into open-mmlab:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants