-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameters of DilatedEncoder #7812
Conversation
Add the original fixed parameter block_dilations as an incoming parameter
…r and fully function annotation
…lated_encoder function is missing block_dilations
In the test process after the first submission, I noticed that the error was reported because the new block_dilations was missing when its test function called DilatedEncoder.
So I fixed the bug in the latest commit |
I noticed that you released v2.24.0, do I need to resubmit on the new version? |
[fix] tests/test_models/test_necks.py:237:80: E501 line too long (84 > 79 characters)
Codecov Report
@@ Coverage Diff @@
## dev #7812 +/- ##
==========================================
- Coverage 64.71% 64.67% -0.04%
==========================================
Files 351 351
Lines 28461 28461
Branches 4807 4807
==========================================
- Hits 18418 18408 -10
- Misses 9055 9066 +11
+ Partials 988 987 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
1 similar comment
* Parameters of DilatedEncoder Add the original fixed parameter block_dilations as an incoming parameter * [Fix] Add default value to block_dilations parameter of DilatedEncoder and fully function annotation * [Fix] The incoming parameter of calling DilatedEncoder in the test_dilated_encoder function is missing block_dilations * Update test_necks.py [fix] tests/test_models/test_necks.py:237:80: E501 line too long (84 > 79 characters)
* Parameters of DilatedEncoder Add the original fixed parameter block_dilations as an incoming parameter * [Fix] Add default value to block_dilations parameter of DilatedEncoder and fully function annotation * [Fix] The incoming parameter of calling DilatedEncoder in the test_dilated_encoder function is missing block_dilations * Update test_necks.py [fix] tests/test_models/test_necks.py:237:80: E501 line too long (84 > 79 characters)
* Parameters of DilatedEncoder Add the original fixed parameter block_dilations as an incoming parameter * [Fix] Add default value to block_dilations parameter of DilatedEncoder and fully function annotation * [Fix] The incoming parameter of calling DilatedEncoder in the test_dilated_encoder function is missing block_dilations * Update test_necks.py [fix] tests/test_models/test_necks.py:237:80: E501 line too long (84 > 79 characters)
* Parameters of DilatedEncoder Add the original fixed parameter block_dilations as an incoming parameter * [Fix] Add default value to block_dilations parameter of DilatedEncoder and fully function annotation * [Fix] The incoming parameter of calling DilatedEncoder in the test_dilated_encoder function is missing block_dilations * Update test_necks.py [fix] tests/test_models/test_necks.py:237:80: E501 line too long (84 > 79 characters)
Add the original fixed parameter block_dilations as an incoming parameter
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
When I used yolof, I modified the modification and found that the parameter named block_dilations of DilatedEncoder is fixed. If I have num_residual_blocks as other values, this parameter cannot be very convenient.
Modification
I modified this parameter of DilatedEncoder to be an incoming parameter and added a default value in its config file.
https://github.com/Shanyaliux/mmdetection/blob/aa99c91d64f4de35ef8040493d0cf5453d662476/mmdet/models/necks/dilated_encoder.py#L68
https://github.com/Shanyaliux/mmdetection/blob/aa99c91d64f4de35ef8040493d0cf5453d662476/mmdet/models/necks/dilated_encoder.py#L74
https://github.com/Shanyaliux/mmdetection/blob/aa99c91d64f4de35ef8040493d0cf5453d662476/configs/yolof/yolof_r50_c5_8x8_1x_coco.py#L25
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist