-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make compatible with ConfigDict
and dict
#8942
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @MambaWong , |
8c81f53
to
5fe9dc8
Compare
LGTM, we can check all codes to avoid this potential error. Such as in gfl_head, mask2former_head, etc. |
RangiLyu
approved these changes
Oct 14, 2022
ZwwWayne
approved these changes
Oct 18, 2022
MambaWong
added a commit
to MambaWong/mmdetection-1
that referenced
this pull request
Oct 20, 2022
… heads (open-mmlab#8942) * make compatible with `ConfigDict` and `dict` * update
MambaWong
added a commit
to MambaWong/mmdetection-1
that referenced
this pull request
Oct 21, 2022
… heads (open-mmlab#8942) * make compatible with `ConfigDict` and `dict` * update
MambaWong
added a commit
to MambaWong/mmdetection-1
that referenced
this pull request
Oct 22, 2022
… heads (open-mmlab#8942) * make compatible with `ConfigDict` and `dict` * update
MambaWong
added a commit
to MambaWong/mmdetection-1
that referenced
this pull request
Oct 22, 2022
… heads (open-mmlab#8942) * make compatible with `ConfigDict` and `dict` * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
AnchorHead
is used as the net head anddict
is used as thetrain_cfg
parameter, an error will be reported.That is because
dict
does not support python object attributes interface liketrain_cfg.assigner
, butConfigDict
does.