Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add eiou impl #9086

Merged
merged 3 commits into from
Oct 27, 2022
Merged

add eiou impl #9086

merged 3 commits into from
Oct 27, 2022

Conversation

Wwupup
Copy link
Contributor

@Wwupup Wwupup commented Oct 20, 2022

Motivation

In paper: A Systematic IoU-Related Method: Beyond Simplified Regression for Better Localization of TIP2021, we propose a new Extended-IOU loss, which outperforms the commonly used GIOU and DIOU in object detection.

Modification

add implementation of the proposed Extended-IOU Loss (EIOU).

Use cases (Optional)

In config:
loss_bbox=dict(type='EIoULoss', loss_weight=1.0, smooth_point=0.1)

@ZwwWayne
Copy link
Collaborator

Hi @Wwupup ,
Thanks for your kind PR. Could you also help to add unit tests?

@Wwupup
Copy link
Contributor Author

Wwupup commented Oct 20, 2022

Hi @Wwupup , Thanks for your kind PR. Could you also help to add unit tests?

Hi, I have made modifications to tests/test_models/test_losses/test_loss.py in my PR, do I need to make any other changes?

@ZwwWayne ZwwWayne added this to the 3.0.0rc3 milestone Oct 21, 2022
@RangiLyu
Copy link
Member

Hi @Wwupup , Thanks for your kind PR. Could you also help to add unit tests?

Hi, I have made modifications to tests/test_models/test_losses/test_loss.py in my PR, do I need to make any other changes?

I think that's enough.

mmdet/models/losses/iou_loss.py Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne merged commit 4510c77 into open-mmlab:dev-3.x Oct 27, 2022
@OpenMMLab-Assistant005
Copy link

Hi @Wwupup !First of all, we want to express our gratitude for your significant PR in the MMDet project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants