Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] dev-1.x change np.transpose to torch.permute for speed up #2277

Merged
merged 2 commits into from
Feb 18, 2023

Conversation

sunjiahao1999
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

dev-1.x change np.transpose to torch.permute. Related mmdet PR open-mmlab/mmdetection#9533.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 46.61% // Head: 47.04% // Increases project coverage by +0.42% 🎉

Coverage data is based on head (8e8f99b) compared to base (f4ae6d7).
Patch coverage: 92.11% of modified lines in pull request are covered.

❗ Current head 8e8f99b differs from pull request most recent head 8b8cf9e. Consider uploading reports for the commit 8b8cf9e to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2277      +/-   ##
===========================================
+ Coverage    46.61%   47.04%   +0.42%     
===========================================
  Files          259      261       +2     
  Lines        21435    21635     +200     
  Branches      3383     3417      +34     
===========================================
+ Hits          9992    10178     +186     
- Misses       10796    10807      +11     
- Partials       647      650       +3     
Flag Coverage Δ
unittests 47.04% <92.11%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/evaluation/__init__.py 100.00% <ø> (ø)
mmdet3d/datasets/transforms/formating.py 56.25% <33.33%> (ø)
mmdet3d/evaluation/metrics/panoptic_seg_metric.py 90.00% <90.00%> (ø)
mmdet3d/evaluation/functional/panoptic_seg_eval.py 93.45% <93.45%> (ø)
mmdet3d/evaluation/functional/__init__.py 100.00% <100.00%> (ø)
mmdet3d/evaluation/metrics/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZwwWayne ZwwWayne merged commit a32c079 into open-mmlab:dev-1.x Feb 18, 2023
xizaoqu pushed a commit to xizaoqu/mmdetection3d that referenced this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants