[Feature] Add groups parameter to Conv2d in ResidualBlockNoBN

[gihwan-kim]

Add groups parameter to Conv2d in ResidualBlockNoBN

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

I'm working on implement acceleration and compression for Super Resolution model to deploy on small device.
I have to use group convolution using conv2d groups parameter. But in mmediting ResidualBlockNoBN has no groups parameter.
So I think groups parameter has to be add to ResidualBlockNoBN for who need group convolution.

Modification

Please briefly describe what modification is made in this PR.

Add groups parameter to Conv2d in ResidualBlockNoBN.

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

• I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
• Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
• Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
• New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
• The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

• If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
• CLA has been signed and all committers have signed the CLA in this PR.

[plyfager]

Sorry for responding later. You may fix the comment so I can merge this PR.
circleci failed for this PR. You may pip install pre-commit and run pre-commit run --all-files to fix this error.

[plyfager]

This may also be useful for branch dev-1.x, we will appreciate it a lot if you can also make a pr to fix this in dev-1.x.

[plyfager]

Hi @gihwan-kim , we'll just handle this PR since hasn't receive further response.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ plyfager
✅ Z-Fran
❌ gihwan-kim
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[plyfager]

Hi @gihwan-kim , Could you sign the CLA so we can merge this PR?

[codecov]

Codecov Report

Base: 83.72% // Head: 83.89% // Increases project coverage by +0.16% 🎉

Coverage data is based on head (d65fce1) compared to base (3a64977).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head d65fce1 differs from pull request most recent head 2c64c14. Consider uploading reports for the commit 2c64c14 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1510      +/-   ##
==========================================
+ Coverage   83.72%   83.89%   +0.16%     
==========================================
  Files         227      227              
  Lines       13027    13027              
  Branches     2027     2027              
==========================================
+ Hits        10907    10929      +22     
+ Misses       1760     1742      -18     
+ Partials      360      356       -4     

Flag	Coverage Δ
unittests	83.89% <100.00%> (+0.16%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
mmedit/models/common/sr_backbone_utils.py	82.35% <100.00%> (ø)
mmedit/models/restorers/basic_restorer.py	95.74% <0.00%> (+23.40%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[OpenMMLab-Assistant001]

Hi @gihwan-kim！First of all, we want to express our gratitude for your significant PR in the MMEditing . Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/UjgXkPWNqA

If you have WeChat account，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution！❤