[Enhance] Make the parameters of get_model_complexity_info() friendly #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shengjiang QUAN <qsj287068067@126.com>
|
|
2 tasks
sjiang95
changed the title
zhouzaida
reviewed
Apr 10, 2023
mmengine/analysis/print_helper.py
Outdated
Comment on lines
700
to
706
| assert (input_shape is not None) or ( | ||
| inputs | ||
| is not None), '"input_shape" and "inputs" cannot both be "None".' | ||
| if (input_shape is not None) and (inputs is not None): | ||
| warnings.warn('Both "input_shape" and "inputs" are provided.\ | ||
| "inputs" will be used.') | ||
|
|
There was a problem hiding this comment.
Directly throwing errors are OK when they are both set.
zhouzaida
reviewed
Apr 10, 2023
zhouzaida
reviewed
Apr 10, 2023
When "input_shape" and "inputs" are both `None` or both set, throw ValueError. Signed-off-by: Shengjiang QUAN <qsj287068067@126.com>
zhouzaida
approved these changes
Apr 10, 2023
zhouzaida
changed the title
xiexinch
added a commit
to open-mmlab/mmsegmentation
that referenced
this pull request
Jan 31, 2024
## Motivation `inputs` and `input_shape` can't be both set to mmengine api `get_model_complexity_info` open-mmlab/mmengine#1056 ## Modification Set `input_shape` to None.
Chrps
pushed a commit
to Chrps/mmsegmentation
that referenced
this pull request
Apr 8, 2024
## Motivation `inputs` and `input_shape` can't be both set to mmengine api `get_model_complexity_info` open-mmlab/mmengine#1056 ## Modification Set `input_shape` to None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Optimize the flexibility of function
get_model_complexity_info(). #1055Modification
input_shapetoNone.assertdoes not allow bothinput_shapeandinputsareNone.input_shapeandinputsare provided, print a warning.BC-breaking (Optional)
It the downstream repo calls the function
get_model_complexity_info()like this line (It seems that the downstream repos have to call this function like the linked line.), not change has to be performed on the existing repos to fit this modification.Use cases (Optional)
Not applicable.
Checklist