Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Handle the case for Multi-Instance GPUs when using cuda_visible_devices #1164

Merged
merged 8 commits into from May 28, 2023

Conversation

adrianjoshua-strutt
Copy link
Contributor

Motivation

Issue

Modification

Deprecate the int() conversion in

mmengine/mmengine/logging/logger.py

Line 379 in 4bc2fe1

@CLAassistant
Copy link

CLAassistant commented May 25, 2023

CLA assistant check
All committers have signed the CLA.

@zhouzaida
Copy link
Member

We also need to update the unit tests in

def test_get_device_id():

@zhouzaida zhouzaida changed the title [Fix] Deprecate cuda_visible_devices int conversion [Enhancement] Handle the case for Multi-Instance GPUs when using cuda_visible_devices May 28, 2023
@zhouzaida zhouzaida added this to the 0.7.4 milestone May 28, 2023
@zhouzaida zhouzaida merged commit 0ff89f7 into open-mmlab:main May 28, 2023
16 of 19 checks passed
@OpenMMLab-Assistant-004

Hi @adrianjoshua-strutt,

We'd like to express our appreciation for your valuable contributions to the mmengine. Your efforts have significantly aided in enhancing the project's quality.
It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: ​https://discord.gg/UjgXkPWNqA.

If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".

Thanks again for your awesome contribution, and we're excited to have you as part of our community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants