Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Handle the case for Multi-Instance GPUs when using cuda_visible_devices #1164

Merged
merged 8 commits into from
May 28, 2023
Merged

[Enhancement] Handle the case for Multi-Instance GPUs when using cuda_visible_devices #1164

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d89bba1
[Fix] Deprecate cuda_visible_devices int conversion
adrianjoshua-strutt May 25, 2023
ef05b47
[FIX] Deprecate int conversion in unit tests.
adrianjoshua-strutt May 26, 2023
355d66c
[Fix] Changed to single quotation marks
adrianjoshua-strutt May 26, 2023
8a418d9
[Fix] Add string conversion for output consistency
adrianjoshua-strutt May 26, 2023
f19ccfc
[Fix] Potential backward compatibility.
adrianjoshua-strutt May 26, 2023
3fe04f0
Changed int conversion check to try/except
adrianjoshua-strutt May 26, 2023
da5c02b
Remove bare except
adrianjoshua-strutt May 26, 2023
c7640b0
Update mmengine/logging/logger.py
zhouzaida May 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion mmengine/logging/logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,12 @@ def _get_device_id():
cuda_visible_devices = list(range(num_device))
else:
cuda_visible_devices = cuda_visible_devices.split(',')
return int(cuda_visible_devices[local_rank])
if cuda_visible_devices[local_rank].isdigit():
return int(cuda_visible_devices[local_rank])
else:
# handle case for Multi-Instance GPUs
# see #1148 for details
return cuda_visible_devices[local_rank]


def _get_host_info() -> str:
Expand Down