[CodeCamp #28] support ReduceOnPlateau #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LEFTeyex
requested review from
RangiLyu,
HAOCHENYE and
zhouzaida
as code owners
|
|
HAOCHENYE
changed the title
… param_schedulers built
HAOCHENYE
reviewed
Dec 14, 2022
Comment on lines
1390
to
1393
| self._init_is_better( | ||
| rule=self.rule, | ||
| threshold=self.threshold, | ||
| threshold_rule=self.threshold_rule) |
There was a problem hiding this comment.
It seems not necessary to call self._init_is_better here. self.__dict__.update(state_dict) will also update its attributes.
There was a problem hiding this comment.
It is necessary when the cfg is different from cfg in state_dict.
LEFTeyex
requested review from
HAOCHENYE
and removed request for
RangiLyu and
zhouzaida
Co-authored-by: Mashiro <57566630+HAOCHENYE@users.noreply.github.com>
… ReduceOnPlateauLR docs
…and ReduceOnPlateauMomentum
HAOCHENYE
reviewed
Jan 9, 2023
HAOCHENYE
previously approved these changes
Jan 9, 2023
HAOCHENYE
previously approved these changes
Jan 9, 2023
zhouzaida
reviewed
Jan 9, 2023
zhouzaida
reviewed
Jan 9, 2023
zhouzaida
reviewed
Jan 14, 2023
| @@ -74,6 +76,72 @@ def test_after_epoch(self): | |||
| scheduler2.step = Mock() | |||
| scheduler2.by_epoch = True | |||
| runner.param_schedulers = dict(key1=[scheduler1], key2=[scheduler2]) | |||
| hook.after_train_iter(runner, 0) | |||
There was a problem hiding this comment.
Is it necessary to call this method here?
zhouzaida
reviewed
Jan 14, 2023
zhouzaida
reviewed
Jan 14, 2023
| scheduler.need_val_args = True | ||
| runner.param_schedulers = scheduler | ||
| hook.after_val_epoch(runner, metrics) | ||
| scheduler.step.assert_called_with(metrics) |
There was a problem hiding this comment.
The step method of scheduler will not be called so this line can be moved to make ut clear.
zhouzaida
reviewed
Jan 14, 2023
zhouzaida
reviewed
Jan 14, 2023
zhouzaida
reviewed
Jan 14, 2023
zhouzaida
reviewed
Jan 14, 2023
zhouzaida
reviewed
Jan 14, 2023
zhouzaida
reviewed
Jan 14, 2023
zhouzaida
reviewed
Jan 14, 2023
|
Hi @LEFTeyex , thanks for your contribution. This PR can be merged after resolving the above comments. |
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
…dd_reduceonplateauparamscheduler
|
Hi @zhouzaida, I have done. |
zhouzaida
approved these changes
Jan 16, 2023
HAOCHENYE
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
The task to support ReduceLROnPlateau in OpenMMLab Code Camp.
Modification
Add
ReduceOnPlateauParamScheduler,ReduceOnPlateauLR,ReduceOnPlateauMomentumclass and addafter_val_epochhook position to support ReduceLROnPlateau.BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
It will be supplemented later.
Checklist