-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CodeCamp #28] support ReduceOnPlateau #819
Merged
zhouzaida
merged 48 commits into
open-mmlab:main
from
LEFTeyex:LEFTeyes/add_reduceonplateauparamscheduler
Jan 16, 2023
Merged
Changes from 42 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
e41c8f6
[Feature] Add ReduceOnPlateauParamScheduler and change ParamScheduler…
LEFTeyex bbab5e3
[Feature] add ReduceOnPlateauLR and ReduceOnPlateauMomentum
LEFTeyex 28ffc49
pre-commit check
LEFTeyex 97419c9
Merge branch 'main' of github.com:open-mmlab/mmengine into LEFTeyes/a…
LEFTeyex aadaf4d
add a little docs
LEFTeyex 3ac869c
change position
LEFTeyex a17217a
fix the conflict between isort and yapf
LEFTeyex 68085fe
fix ParamSchedulerHook after_val_epoch execute without train_loop and…
LEFTeyex 68bddd8
Apply suggestions from code review
LEFTeyex 97f0468
update ReduceOnPlateauParamScheduler, ReduceOnPlateauMomentum and Par…
LEFTeyex 83f4313
fix get need_step_args attribute error in ParamSchedulerHook
LEFTeyex f84fd9e
fix load_state_dict error for rule in ReduceOnPlateauParamScheduler
LEFTeyex f116a50
add docs for ParamSchedulerHook and fix a few codes
LEFTeyex 57a1ee5
[Docs] add ReduceOnPlateauParamScheduler, ReduceOnPlateauMomentum and…
LEFTeyex e19e34e
[Refactor] adjust the order of import
LEFTeyex 7b9e19f
[Fix] add init check for threshold in ReduceOnPlateauParamScheduler
LEFTeyex 9e0e0c7
[Test] add test for ReduceOnPlateauParamScheduler, ReduceOnPlateauLR …
LEFTeyex 0978665
Merge branch 'main' of github.com:open-mmlab/mmengine into LEFTeyes/a…
LEFTeyex 70cf761
[Fix] fix no attribute self.min_value
LEFTeyex 4ecde19
[Fix] fix numerical problem in tests
LEFTeyex c8fcfae
[Fix] fix error in tests
LEFTeyex bb2a535
[Fix] fix ignore first param in tests
LEFTeyex 11497d0
[Fix] fix bug in tests
LEFTeyex 284bb6c
[Fix] fix bug in tests
LEFTeyex c309081
[Fix] fix bug in tests
LEFTeyex c80e7f0
[Fix] increase coverage
LEFTeyex ce4b4e2
[Fix] fix count self._global_step bug and docs
LEFTeyex f07110c
[Fix] fix tests
LEFTeyex f93ea75
[Fix] modified ParamSchedulerHook test
LEFTeyex 2acec59
Update mmengine/optim/scheduler/param_scheduler.py
LEFTeyex 37c4fce
Apply suggestions from code review
LEFTeyex 98280b2
[Fix] modified something according to commented
LEFTeyex 66046ea
[Docs] add api for en and zh_cn
LEFTeyex 9fcacbf
[Fix] fix bug in test_param_scheduler_hook.py
LEFTeyex 6058dd1
[Test] support more complicated test modes(less, greater, rel, abs) f…
LEFTeyex f3ab5bf
[Docs] add docs for rule
LEFTeyex 3d6cbd8
[Fix] fix pop from empty list bug in test
LEFTeyex 00d40d4
[Fix] fix check param_schedulers is not built bug
LEFTeyex 84c114e
Merge branch 'main' of github.com:open-mmlab/mmengine into LEFTeyes/a…
LEFTeyex c405e56
[Fix] fix step_args bug and without runner._train_loop bug
LEFTeyex 8c69c5d
[Fix] fix step_args bug and without runner._train_loop bug
LEFTeyex d4f6641
[Fix] fix scheduler type bug
LEFTeyex 85f98e3
[Test] rename step_args to step_kwargs
LEFTeyex 516f9a3
[Fix] remove redundancy check
LEFTeyex 61798cd
[Test] remove redundancy check
LEFTeyex 9504c6d
Apply suggestions from code review
LEFTeyex 9b561d7
[Test] fix some defects
LEFTeyex c96b84f
Merge branch 'main' of github.com:open-mmlab/mmengine into LEFTeyes/a…
LEFTeyex File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to change the position of
step
method?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Save the time to build
step
, whenrunner.param_schedulers is None
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. BTW, it is unnecessary to rename
param_schedulers
to_param_schedulers
instep
method.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change
_param_schedulers
back toparam_schedulers
.