Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add bleu metric and its test file #66

Merged
merged 16 commits into from
Dec 19, 2022

Conversation

go-with-me000
Copy link
Contributor

Motivation

The task of PR this time is to specifically implement the metric of BLEU. I have completed the implementation of BLEU and provided test files to test functions.

Modification

The bleu code file and the corresponding test file are provided. Simple modifications are made to the code that does not conform to the specification. At the same time, BLEU is added to the document.

Checklist

  1. Add bleu metric code
  2. Provide test files for bleu
  3. Make simple modifications to individual files to conform to the commit standard

@go-with-me000 go-with-me000 marked this pull request as draft December 12, 2022 07:55
@go-with-me000 go-with-me000 marked this pull request as ready for review December 12, 2022 07:56
@go-with-me000 go-with-me000 marked this pull request as draft December 12, 2022 07:56
@go-with-me000 go-with-me000 marked this pull request as ready for review December 12, 2022 08:04
@go-with-me000 go-with-me000 marked this pull request as draft December 12, 2022 08:06
@go-with-me000 go-with-me000 marked this pull request as ready for review December 12, 2022 08:08
@go-with-me000 go-with-me000 marked this pull request as draft December 12, 2022 08:11
@go-with-me000 go-with-me000 marked this pull request as ready for review December 12, 2022 08:11
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/end_point_error.py Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Dec 13, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@ice-tong ice-tong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the following comments

mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
@ice-tong
Copy link
Collaborator

Please @yhcc @zhouzaida have a look~

mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
mmeval/metrics/bleu.py Outdated Show resolved Hide resolved
@zhouzaida zhouzaida merged commit 7f60d59 into open-mmlab:main Dec 19, 2022
@jason102811
Copy link

Dear go-with-me000,
First of all, we want to express our gratitude for your significant PR in the MMEval . Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
As a valued contributor, we would also like to invite you to join our Special Interest Group (SIG) private channel, where you can share your experiences, ideas, and build connections with like-minded peers.
Join us :https://discord.gg/raweFPmdzG
To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. We look forward to seeing you there!
Also,if you have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx,or scan the following QR code to join us. Please add "mmsig + Github ID" as a remark when adding friends:)
Best regards! @go-with-me000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants