[Fix] db_module_loss,negative number encountered in sqrt #1640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
训练自定义数据集时遇到RuntimeWarning如下
调试定位到出错原因如下:
由于pt1, pt2都是float32,计算a_square, b_square, c_square存在数值精度问题
导致后续根据余弦公式计算neg_cos_c时出现了小于-1或者大于1的情况
从而使得计算distance时sqrt下a_square * b_square * square_sin 出现负数
mmocr/mmocr/models/textdet/module_losses/db_module_loss.py
Lines 278 to 294 in 24bfb18
Modification
解决方法:
将计算得到的neg_cos_c值进一步限制在[-1,1]间
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
可以复现该问题的case
xs = [[0,1,2,...,35, 36], [0,1,2,...,35, 36],..., [0,1,2,...,35, 36], [0,1,2,...,35, 36],],shape=(22,37)
ys = [[0,0,...,0,0], [1,1,...,1,1],..., [20,20,...,20,20], [21,21,...,21,21]],shape=(22,37)
pt1 = array([4.8011017, 18.335022], dtype=float32)
pt2 = array([3.2233124, 7.532318], dtype=float32)
Checklist
Before PR:
After PR: