Protect against dangerous default value. #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innerlee
reviewed
Nov 10, 2020
| @@ -75,6 +77,7 @@ def __init__(self, | |||
| middle_channels=32, | |||
| num_stages=6, | |||
| norm_cfg=dict(type='BN', requires_grad=True)): | |||
| norm_cfg = copy.deepcopy(norm_cfg) | |||
There was a problem hiding this comment.
need to add that line of comment, so that future reader know what this line is for
yaochaorui
force-pushed
the
ycr/W0102
branch
from
b0619e9
to
91fe125
Compare
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
==========================================
+ Coverage 83.03% 83.74% +0.71%
==========================================
Files 112 113 +1
Lines 6448 6860 +412
Branches 1029 1083 +54
==========================================
+ Hits 5354 5745 +391
- Misses 901 918 +17
- Partials 193 197 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
innerlee
approved these changes
Nov 12, 2020
innerlee
reviewed
Nov 12, 2020
mmpose/models/backbones/cpm.py
Outdated
| @@ -75,6 +77,8 @@ def __init__(self, | |||
| middle_channels=32, | |||
| num_stages=6, | |||
| norm_cfg=dict(type='BN', requires_grad=True)): | |||
| # Protect against dangerous default value. | |||
There was a problem hiding this comment.
Use
Protect mutable default arguments
There was a problem hiding this comment.
The default values are not "dangerous" without knowing the context
yaochaorui
force-pushed
the
ycr/W0102
branch
from
b74f6e5
to
22ba40f
Compare
innerlee
approved these changes
Nov 12, 2020
wusize
pushed a commit
that referenced
this pull request
Nov 13, 2020
* Protect against dangerous default value. * Added comments.
rollingman1
pushed a commit
to rollingman1/mmpose
that referenced
this pull request
Nov 5, 2021
* make 'FrameSelector' registered * update changelog * update changelog * Update changelog.md
shuheilocale
pushed a commit
to shuheilocale/mmpose
that referenced
this pull request
May 6, 2023
* Protect against dangerous default value. * Added comments.
HAOCHENYE
added a commit
to HAOCHENYE/mmpose
that referenced
this pull request
Jun 27, 2023
…b#268) * add base model, ddp model and unit test * add unit test * fix unit test * fix docstring * fix cpu unit test * refine base data preprocessor * refine base data preprocessor * refine interface of ddp module * remove optimizer hook * add forward * fix as comment * fix unit test * fix as comment * fix build optimizer wrapper * rebase main and fix unit test * stack_batch support stacking ndim tensor, add docstring for merge dict * fix lint * fix test loop * make precision_context effective to data_preprocessor * fix as comment * fix as comment * refine docstring * change collate_data output typehints * rename to_rgb to bgr_to_rgb and rgb_to_bgr * support build basemodel with built DataPreprocessor * fix as comment * fix docstring
ajgrafton
pushed a commit
to ajgrafton/mmpose
that referenced
this pull request
Mar 6, 2024
* Protect against dangerous default value. * Added comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #240