Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename heads detectors #667

Merged
merged 8 commits into from
Jun 2, 2021
Merged

Rename heads detectors #667

merged 8 commits into from
Jun 2, 2021

Conversation

jin-s13
Copy link
Collaborator

@jin-s13 jin-s13 commented May 24, 2021

  1. Rename heads
BottomUpHigherResolutionHead -> AEHigherResolutionHead
BottomUpSimpleHead -> AESimpleHead
TopDownSimpleHead->TopdownHeatmapSimpleHead
TopDownMultiStageHead->TopdownHeatmapMultiStageHead
TopDownMSMUHead->TopdownHeatmapMSMUHead
MeshHMRHead->HMRMeshHead
  1. Rename detectors
BottomUp -> AssociativeEmbedding
  1. move mesh_heads/* and keypoint_heads/*, to heads/
  2. move discriminator.py to misc/

@jin-s13 jin-s13 marked this pull request as draft May 24, 2021 14:04
@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #667 (4ba8a1e) into master (8134b29) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 4ba8a1e differs from pull request most recent head 170d941. Consider uploading reports for the commit 170d941 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
+ Coverage   82.90%   82.91%   +0.01%     
==========================================
  Files         167      166       -1     
  Lines       12505    12548      +43     
  Branches     2037     2045       +8     
==========================================
+ Hits        10367    10404      +37     
- Misses       1617     1623       +6     
  Partials      521      521              
Flag Coverage Δ
unittests 82.91% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/models/__init__.py 100.00% <0.00%> (ø)
mmpose/models/keypoint_heads/__init__.py
mmpose/models/mesh_heads/geometric_layers.py
mmpose/models/keypoint_heads/top_down_base_head.py
mmpose/models/detectors/bottom_up.py
mmpose/models/mesh_heads/hmr_head.py
.../models/keypoint_heads/temporal_regression_head.py
mmpose/models/mesh_heads/__init__.py
...keypoint_heads/bottom_up_higher_resolution_head.py
...pose/models/keypoint_heads/top_down_simple_head.py
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8134b29...170d941. Read the comment docs.

@jin-s13
Copy link
Collaborator Author

jin-s13 commented May 26, 2021

I did not modify the config files for now. The old configs will also work (with warnings).

@jin-s13 jin-s13 marked this pull request as ready for review May 26, 2021 06:36
@jin-s13 jin-s13 requested a review from ly015 May 26, 2021 06:36
@innerlee innerlee merged commit a62f918 into master Jun 2, 2021
@innerlee innerlee deleted the rename_heads_detectors branch June 2, 2021 14:43
@jin-s13 jin-s13 mentioned this pull request Jun 20, 2021
minoki pushed a commit to minoki/mmpose that referenced this pull request Jul 13, 2021
* rename heads

* mesh

* move discriminator in models.module

* rename detectors

* update api.rst

* fix unnittest

* add deprecationWarning

* fix
rollingman1 pushed a commit to rollingman1/mmpose that referenced this pull request Nov 5, 2021
* fix bugs

* modify module register

* modify var name

* modify unittest
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* rename heads

* mesh

* move discriminator in models.module

* rename detectors

* update api.rst

* fix unnittest

* add deprecationWarning

* fix
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* rename heads

* mesh

* move discriminator in models.module

* rename detectors

* update api.rst

* fix unnittest

* add deprecationWarning

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants