Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix typo in usage example #1003

Merged
merged 1 commit into from
Oct 28, 2021
Merged

[Fix] Fix typo in usage example #1003

merged 1 commit into from
Oct 28, 2021

Conversation

lkm2835
Copy link
Contributor

@lkm2835 lkm2835 commented Oct 28, 2021

Fix typo in configs/segformer/README.md

line 32,
swin2mmseg.py --> mit2mmseg.py

@CLAassistant
Copy link

CLAassistant commented Oct 28, 2021

CLA assistant check
All committers have signed the CLA.

@MengzhangLI MengzhangLI changed the title Fix typo in usage example [Fix] Fix typo in usage example Oct 28, 2021
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (93f8b14) to head (525bb6b).
Report is 310 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1003   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files         118      118           
  Lines        6558     6558           
  Branches     1019     1019           
=======================================
  Hits         5893     5893           
  Misses        464      464           
  Partials      201      201           
Flag Coverage Δ
unittests 89.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MengzhangLI
Copy link
Contributor

Hi, @lkm2835
Please fix the lint error!

Thanks for your nice PR.

@lkm2835
Copy link
Contributor Author

lkm2835 commented Oct 28, 2021

I don't understand why the lint error occurred. Can you advise how to fix it?
I just modified one line with vscode.

@MengzhangLI
Copy link
Contributor

I don't understand why the lint error occurred. Can you advise how to fix it? I just modified one line with vscode.

It is usually caused by code format, you could use pre-commit to overcome it.

Here are Chinese article and English document, hoping it is useful to you.

Thanks for your help!

@Junjun2016
Copy link
Collaborator

Can click Details to check why the specific CI item failed.

@Junjun2016
Copy link
Collaborator

image

@Junjun2016
Copy link
Collaborator

Junjun2016 commented Oct 28, 2021

Can click Details to check why the specific CI item failed.

Rerun the CI worked.
It seems to be the problem with the github server.

@lkm2835
Copy link
Contributor Author

lkm2835 commented Oct 28, 2021

I'm sorry, I accidentally used master branch for PR.
Is it a problem?

@Junjun2016
Copy link
Collaborator

I'm sorry, I accidentally used master branch for PR. Is it a problem?

It is fine for this PR.
It is better to checkout a new branch for new PR (one branch for one feature).

@Junjun2016 Junjun2016 merged commit 9feaa7c into open-mmlab:master Oct 28, 2021
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
…repare_mask_and_masked_image` (open-mmlab#1003)

* Handle batches and Tensors in `prepare_mask_and_masked_image`

* `blackfy`
upgrade `black`

* handle mask as `np.array`

* add docstring

* revert `black` changes with smaller line length

* missing ValueError in docstring

* raise `TypeError` for image as tensor but not mask

* typo in mask shape selection

* check for batch dim

* fix: wrong indentation

* add tests

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
@jason102811
Copy link

lkm2835,您好!您在MMSeg项目中给我们提的PR非常重要,感谢您付出私人时间帮助改进开源项目,相信很多开发者会从你的PR中受益。
我们非常期待与您继续合作,OpenMMLab专门成立了贡献者组织MMSIG,为贡献者们提供开源证书、荣誉体系和专享好礼,可通过添加微信:openmmlabwx 联系我们(请备注mmsig+GitHub id),由衷希望您能加入!
Dear lkm2835,
First of all, we want to express our gratitude for your significant PR in the MMSeg project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
We are looking forward to continuing our collaboration with you. OpenMMLab has established a special contributors' organization called MMSIG, which provides contributors with open-source certificates, a recognition system, and exclusive rewards. You can contact us by adding our WeChat(if you have WeChat): openmmlabwx, or join in our discord: https://discord.gg/qH9fysxPDW. We sincerely hope you will join us!
Best regards @lkm2835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants