Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix ATTENTION registry #729

Merged
merged 2 commits into from
Jul 27, 2021

Conversation

Junjun2016
Copy link
Collaborator

@Junjun2016 Junjun2016 commented Jul 26, 2021

Motivation

Register ATTENTION registry from the parent ATTENTION registry of MMCV to avoid conflict with other repos

Fix open-mmlab/mmpretrain#369

Modification

Using mmseg ATTENTION registry to register attention modules.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
No

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #729 (ec8661a) into master (feeac01) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head ec8661a differs from pull request most recent head a350b82. Consider uploading reports for the commit a350b82 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #729   +/-   ##
=======================================
  Coverage   85.28%   85.28%           
=======================================
  Files         107      107           
  Lines        5817     5818    +1     
  Branches      952      952           
=======================================
+ Hits         4961     4962    +1     
  Misses        673      673           
  Partials      183      183           
Flag Coverage Δ
unittests 85.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/backbones/swin.py 86.85% <100.00%> (-0.05%) ⬇️
mmseg/models/builder.py 92.00% <100.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feeac01...a350b82. Read the comment docs.

Copy link
Member

@mzr1996 mzr1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Junjun2016 Junjun2016 merged commit 4b218bc into open-mmlab:master Jul 27, 2021
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
* register ATTENTION registry from the parent ATTENTION registry of MMCV to avoid conflict with other repos

* remove redundant file
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
* fix accelerate for testing

* fix copies

* uP
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
This PR adds a webcam demo tool with the following features:

1. Read video stream from the webcam or offline video file
2. Async model inference (detection + human pose + animal pose) and video I/O
3. Optimized visualization functions of bbox, object label, and pose
4. Apply special effects (sunglasses or bug-eye)
5. Show statistic information, e.g., FPS, CPU usage.
6. Optionally, save out the video
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] mmcls and mmseg clash with KeyError: 'ShiftWindowMSA is already registered in attention'
2 participants