Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add contiguous after permutation in ViT #992

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

HarborYuan
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Similar with swin impl

Modification

Trivial modification

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@Junjun2016
Copy link
Collaborator

Hi @HarborYuan
Thanks for your contribution.

@Junjun2016 Junjun2016 changed the title vit contiguous [Fix] Add contiguous after permutation in ViT Oct 24, 2021
@Junjun2016
Copy link
Collaborator

Hi @HarborYuan
The CI has been fixed, please merge the master branch.

@HarborYuan
Copy link
Contributor Author

HarborYuan commented Oct 25, 2021

Hi @HarborYuan
The CI has been fixed, please merge the master branch.

Merge the master branch? @Junjun2016

@Junjun2016
Copy link
Collaborator

Hi @HarborYuan
The CI has been fixed, please merge the master branch.

Merge the master branch? @Junjun2016

Yes, we have updated the CI in PR #994 (merged), so please merge the upstream master to your PR.

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #992 (3450626) into master (e27017e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #992   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files         118      118           
  Lines        6558     6558           
  Branches     1019     1019           
=======================================
  Hits         5893     5893           
  Misses        464      464           
  Partials      201      201           
Flag Coverage Δ
unittests 89.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/backbones/vit.py 87.11% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e27017e...3450626. Read the comment docs.

@Junjun2016 Junjun2016 merged commit 93f8b14 into open-mmlab:master Oct 25, 2021
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
* fix batch_size=1 for bottom_up inference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants