[Enhance] Support MMCLI #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OceanPang
reviewed
May 14, 2021
MANIFEST.in
Outdated
| include mmtrack/tools/*.py | ||
| include mmtrack/tools/*.sh | ||
| include mmtrack/tools/*/*.py | ||
| include mmtrack/demo/* |
There was a problem hiding this comment.
- Use recursive-include to update the code, refer here
- Add an empty line at the end of the file.
There was a problem hiding this comment.
I have fixed these two issues.
setup.py
Outdated
| @@ -135,7 +135,8 @@ def gen_packages_items(): | |||
| author_email='openmmlab@gmail.com', | |||
| keywords='computer vision, object tracking, video object detection', | |||
| url='https://github.com/open-mmlab/mmtracking', | |||
| packages=find_packages(exclude=('configs', 'tools', 'demo')), | |||
| packages=find_packages(), | |||
There was a problem hiding this comment.
Why do you modify here?
There was a problem hiding this comment.
I have modified the code back.
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
==========================================
+ Coverage 68.36% 68.74% +0.38%
==========================================
Files 85 85
Lines 4188 4188
Branches 816 816
==========================================
+ Hits 2863 2879 +16
+ Misses 1051 1039 -12
+ Partials 274 270 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
OceanPang
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support installing MMTracking with MMCLI.