Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix visualization in sot demo #213

Merged
merged 4 commits into from
Jul 17, 2021

Conversation

ToumaKazusa3
Copy link
Contributor

This PR fixs the visualization in sot demo. In function cv2.rectangle, the coordinate points of the bbox need to be np.int instead of np.float. For more details, please refer to here.

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #213 (6a99fd2) into master (11d2a1c) will increase coverage by 0.02%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
+ Coverage   69.64%   69.67%   +0.02%     
==========================================
  Files          87       87              
  Lines        4395     4402       +7     
  Branches      863      863              
==========================================
+ Hits         3061     3067       +6     
- Misses       1047     1048       +1     
  Partials      287      287              
Flag Coverage Δ
unittests 69.60% <42.85%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmtrack/models/sot/base.py 49.51% <42.85%> (-0.49%) ⬇️
mmtrack/datasets/pipelines/transforms.py 85.31% <0.00%> (-2.82%) ⬇️
mmtrack/datasets/sot_train_dataset.py 81.81% <0.00%> (-1.02%) ⬇️
mmtrack/models/mot/trackers/tracktor_tracker.py 78.57% <0.00%> (+15.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11d2a1c...6a99fd2. Read the comment docs.

mmtrack/models/sot/base.py Outdated Show resolved Hide resolved
mmtrack/models/sot/base.py Outdated Show resolved Hide resolved

Args:
img (str or ndarray): The image to be displayed.
result (ndarray): ndarray of shape (4. ).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(4, )


Args:
img (str or ndarray): The image to be displayed.
result (ndarray): ndarray of shape (4. ).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(4, ).

@GT9505 GT9505 merged commit b3eedb1 into open-mmlab:master Jul 17, 2021
@ToumaKazusa3 ToumaKazusa3 deleted the fix_sot_demo branch August 25, 2021 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants