Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix cocoapi in parser #218

Closed
wants to merge 1 commit into from
Closed

[Fix] fix cocoapi in parser #218

wants to merge 1 commit into from

Conversation

stacezhou
Copy link

  • [Fix] fix cocoapi in parser as what mmdetection have done #4399
  • fix a bug

* [Fix] fix cocoapi in parser
* fix a bug
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #218 (8adfbc5) into master (b3eedb1) will increase coverage by 0.10%.
The diff coverage is 88.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
+ Coverage   69.96%   70.07%   +0.10%     
==========================================
  Files          87       88       +1     
  Lines        4402     4427      +25     
  Branches      863      864       +1     
==========================================
+ Hits         3080     3102      +22     
- Misses       1037     1039       +2     
- Partials      285      286       +1     
Flag Coverage Δ
unittests 70.00% <88.46%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmtrack/datasets/parsers/coco_api.py 87.50% <87.50%> (ø)
mmtrack/datasets/parsers/coco_video_parser.py 68.75% <100.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3eedb1...8adfbc5. Read the comment docs.

@GT9505
Copy link
Collaborator

GT9505 commented Jul 22, 2021

Hi~, can you fix the lint error firstly?
Besides, we don't need copy the COCO class from mmdet. We can directly import it (from mmdet.datasets.api_wrappers import COCO).

@GT9505
Copy link
Collaborator

GT9505 commented Jul 22, 2021

Please also modify the mmpycocotools to pycocotools in requirements/runtime.txt, just like #4399 did.

@GT9505
Copy link
Collaborator

GT9505 commented Sep 8, 2021

This PR is fixed in #263 , therefore, I will close this PR

@GT9505 GT9505 closed this Sep 8, 2021
@OpenMMLab-Coodinator
Copy link

Hi @stacezhou !We are grateful for your efforts in helping improve this open-source project during your personal time.
Welcome to join OpenMMLab Special Interest Group (SIG) , where you can share your experiences, ideas, and build connections with like-minded peers.

To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants