[Enhancement] Refactor TrackingNetDataset, SOTCocoDataset and SOTImageNetVIDDataset based on BaseSOTDataset #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
==========================================
+ Coverage 70.25% 70.48% +0.23%
==========================================
Files 114 116 +2
Lines 5981 6113 +132
Branches 1157 1181 +24
==========================================
+ Hits 4202 4309 +107
- Misses 1428 1448 +20
- Partials 351 356 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
GT9505
reviewed
Jan 22, 2022
| num_chunks (int, optional): the number of chunks. Some methods may | ||
| only use part of the dataset. Default to all chunks, 12. | ||
| """ | ||
| self.num_chunks = num_chunks |
There was a problem hiding this comment.
The num_chunks should not be a int, since the user may want to specify the index of chunks. It should be a list with optional values in [1,2,3,4,'all']
GT9505
reviewed
Jan 25, 2022
GT9505
approved these changes
Jan 25, 2022
GT9505
changed the title
GT9505
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor TrackingNetDataset, SOTCocoDataset and SOTImageNetVIDDataset based on BaseSOTDataset.
Please refer to #393 for more details.