tests/backends.c: fix a failure when /sys isn't available on Linux on non-x86 #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… non-x86 Since 2.9, Linux discovery aborts if /sys isn't available. Usually it will fallback to the x86 backend... except on non-x86 platforms obviously where it would fallback to "noos" instead. The hwloc_backends.c test verified that the "Backend" info attribute was the same in the XML-loaded topology and the original topology, but it did not handle the case where that info attribute did not exist at all, which is the case when only "noos" is used. This is first reported by Simon South on https://issues.guix.gnu.org/61493 Thanks to Ludovic Courtes for forwarding to me. Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
mbakke
pushed a commit
to guix-mirror/guix
that referenced
this pull request
Apr 7, 2023
* gnu/packages/mpi.scm (hwloc-2): Update to 2.9.1. Patch to skip tests requiring /sys on non-x86 systems should not be necessary anymore, as open-mpi/hwloc#570 has been merged in this new version. Signed-off-by: Ludovic Courtès <ludo@gnu.org>
mbakke
pushed a commit
to guix-mirror/guix
that referenced
this pull request
Apr 12, 2023
* gnu/packages/mpi.scm (hwloc-2): Update to 2.9.1. Patch to skip tests requiring /sys on non-x86 systems should not be necessary anymore, as open-mpi/hwloc#570 has been merged in this new version. Signed-off-by: Ludovic Courtès <ludo@gnu.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 2.9, Linux discovery aborts if /sys isn't available. Usually it will fallback to the x86 backend... except on non-x86 platforms obviously where it would fallback to "noos" instead.
The hwloc_backends.c test verified that the "Backend" info attribute was the same in the XML-loaded topology and the original topology, but it did not handle the case where that info attribute did not exist at all, which is the case when only "noos" is used.
This is first reported by Simon South on https://issues.guix.gnu.org/61493
Thanks to Ludovic Courtes for forwarding to me.