Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openib btl: APM and async events support #31

Closed
ompiteam opened this issue Oct 1, 2014 · 5 comments
Closed

openib btl: APM and async events support #31

ompiteam opened this issue Oct 1, 2014 · 5 comments
Assignees
@shamisp
Labels
bug
Milestone
Future

Comments

@ompiteam
Copy link
Contributor

ompiteam commented Oct 1, 2014

APM support should always be in a background thread so that it can be handled ASAP. The async event handler can be a bit lazier.

For v1.3, the async handler and APM handler are always off in a separate progression thread. For v1.3.1, we should change this strategy:

  • The async handler should use the openib_fd stuff, such that it will be off in its own thread in the case of HAVE_THREAD_SUPPORT. Otherwise, it uses libevent and is called back in the usual single-threaded model.
  • The APM handler should use the openib fd stuff in the case of HAVE_THREAD_SUPPORT, but otherwise should fork off its own thread.
@ompiteam ompiteam added this to the Future milestone Oct 1, 2014
@ompiteam ompiteam added the bug label Oct 1, 2014
@ompiteam
Copy link
Contributor Author

ompiteam commented Oct 1, 2014

Imported from trac issue 1240. Created by jsquyres on 2008-03-11T17:27:21, last modified: 2008-06-01T07:47:34

@ompiteam
Copy link
Contributor Author

ompiteam commented Oct 1, 2014

Trac comment by jsquyres on 2008-05-29 20:14:33:

Pasha -- since basic APM support is in, is this a 1.3 ticket?

@ompiteam
Copy link
Contributor Author

ompiteam commented Oct 1, 2014

Trac comment by pasha on 2008-06-01 05:39:11:

Jeff,
The ticket is not about APM support it is about how we want to handle ASYNC events.
If I remember correct we wanted to merge all thread in single one. I still not completely sure that it is good idea. Anyway this ticket should not be blocker.

@ompiteam
Copy link
Contributor Author

ompiteam commented Oct 1, 2014

Trac comment by jsquyres on 2008-06-01 07:47:34:

You're right -- I didn't read the ticket closely (just keyed in on "APM" in the title). This will require more discussion -- let's move it to v1.4.

yosefe pushed a commit to yosefe/ompi that referenced this issue Mar 5, 2015
@mike-dubman
Merge pull request open-mpi#31 from miked-mellanox/topic/mkey_recursi…
0b11649 
…on_fix

OSHMEM: fix infinite recursion
lrrajesh pushed a commit to lrrajesh/ompi that referenced this issue Mar 19, 2015
@vpedabal
Nodepower plugin
e545ebe 
Fixes open-mpi#31
@gonnetp gonnetp mentioned this issue Oct 31, 2018
Closed
@hjelmn hjelmn mentioned this issue Jan 15, 2019
Closed
devreal added a commit to devreal/ompi that referenced this issue Sep 9, 2020
@devreal
ADAPT: use the correct nbc request type (open-mpi#31)
5c271b9 
* ADAPT: use the correct nbc request type
* coll/base: document type casts in ompi_coll_base_retain_*

Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
@bosilca bosilca mentioned this issue Sep 9, 2020
Merged
devreal pushed a commit to devreal/ompi that referenced this issue Sep 11, 2020
@bosilca
Fix ADAPT for few corner cases
b0de06f 
Add support for fallback to previous coll module on non-commutative operations (open-mpi#30)
Replace mutexes by atomic operations.
Use the correct nbc request type (open-mpi#31)
* coll/base: document type casts in ompi_coll_base_retain_*
Other minor fixes.

Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
Signed-off-by: Joseph Schuchart <schuchart@hlrs.de>
@awlauria
Copy link
Contributor

Openib btl is removed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shamisp shamisp

Labels
bug
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@ompiteam @shamisp @awlauria