mca: Dynamic components link against project lib #4140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This script will search for all of the `Makefile.am` files in each
of the project-level components. Then it adds the project-level
library to `mca_FRAMEWORK_COMPONENT_la_LIBADD`.
- If the library is already in the LIBADD list then it's skipped.
So it is safe to run multiple times on the same codebase.
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
(cherry picked from commit 7a3f1ff)
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
jjhursey
changed the title
* Resolves open-mpi#3705 * Components should link against the project level library to better support `dlopen` with `RTLD_LOCAL`. * Extend the `mca_FRAMEWORK_COMPONENT_la_LIBADD` in the `Makefile.am` with the appropriate project level library: ``` MCA components in ompi/ $(top_builddir)/ompi/lib@OMPI_LIBMPI_NAME@.la MCA components in orte/ $(top_builddir)/orte/lib@ORTE_LIB_PREFIX@open-rte.la MCA components in opal/ $(top_builddir)/opal/lib@OPAL_LIB_PREFIX@open-pal.la MCA components in oshmem/ $(top_builddir)/oshmem/liboshmem.la" ``` Note: The changes in this commit were automated by the script in the commit that proceeds it with the `libadd_mca_comp_update.py` script. Some components were not included in this change because they are statically built only. Signed-off-by: Joshua Hursey <jhursey@us.ibm.com> Local application of the LIBADD script: `./contrib/libadd_mca_comp_update.py` Reference `master` commit e1d0795
* See discussion on Issue open-mpi#3705 regarding why this is no longer needed. Signed-off-by: Joshua Hursey <jhursey@us.ibm.com> (cherry picked from commit 49c40f0) Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
jjhursey
force-pushed
the
explore/v3.0.x/dlopen-local
branch
from
fddefea
to
ab14746
Compare
|
Posting for consideration (if there is another rc) for v3.0.0. Otherwise it can slip to v3.0.1 |
bwbarrett
approved these changes
Sep 5, 2017
|
@jsquyres I confirm the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mastersupport
dlopenwithRTLD_LOCAL.using the
mca_FRAMEWORK_COMPONENT_la_LIBADDin theMakefile.am.Note: The changes in this commit were automated. Some components
were not included because they are statically built only.