opal/atomic: work around memory barrier bug in older gcc #6711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue seem with some older versions of gcc (verified to occur in gcc 6.x) where on x86_64 systems the acquire memory barrier in C11 atomics acts as a no-op. On these systems the three memory barriers should all be equivalent. This is related to the error fixed in open-mpi/ompi@30119ee. References open-mpi#6655. Signed-off-by: Nathan Hjelm <hjelmn@google.com>
hppritcha
approved these changes
May 30, 2019
rhc54
added a commit
to rhc54/openpmix
that referenced
this pull request
Jun 7, 2019
Backport of open-mpi/ompi#6711 Signed-off-by: Ralph Castain <rhc@pmix.org>
rhc54
added a commit
to rhc54/openpmix
that referenced
this pull request
Jun 25, 2019
Backport of open-mpi/ompi#6711 Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit a3d568e)
rhc54
added a commit
to rhc54/openpmix
that referenced
this pull request
Jun 26, 2019
Backport of open-mpi/ompi#6711 Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit a3d568e)
karasevb
pushed a commit
to karasevb/pmix
that referenced
this pull request
Aug 19, 2019
Backport of open-mpi/ompi#6711 Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit a3d568e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue seem with some older versions of gcc
(verified to occur in gcc 6.x) where on x86_64 systems the
acquire memory barrier in C11 atomics acts as a no-op. On these
systems the three memory barriers should all be equivalent.
This is related to the error fixed in 30119ee.
References #6655.
Signed-off-by: Nathan Hjelm hjelmn@google.com