Fix span isRecording #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…correct span.isRecording logic to return false when not being sampled
…ment instead of all 3
Aneurysm9
reviewed
Mar 26, 2021
tests and check for when span is ended immediately
Aneurysm9
reviewed
Mar 29, 2021
Improve readability of test name Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Improve readability of test name Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Aneurysm9
approved these changes
Mar 29, 2021
alolita
approved these changes
Mar 29, 2021
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update SpanSnapshot to use parent SpanContext Having only the parent span ID and a separate field to communicate if the parent was remote does not provide a comprehensive view of the parent span nor is it an efficient way to transmit this information. Update the SpanSnapshot to have a `Parent` field that contains the parent span context. This field replaces the ParentSpanID and HasRemoteParent fields. * Revert SamplingParameters span change * Update CHANGELOG with PR number
* Update SamplingParameters Remove HasRemoteParent fields from SamplingParameters. The HasRemoteParent field is a duplicate of the Remote field of the parent span context contained in the ParentContext. Change the `ParentContext` field from storing a `SpanContext` to a `context.Context` that holds the parent span. This is to conform with the OpenTelemetry specification and resolve open-telemetry#1727. * Update PR number
Codecov Report
@@ Coverage Diff @@
## main #67 +/- ##
========================================
+ Coverage 39.8% 78.1% +38.2%
========================================
Files 179 132 -47
Lines 13942 6948 -6994
========================================
- Hits 5562 5430 -132
+ Misses 8023 1272 -6751
+ Partials 357 246 -111
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-telemetry#1664
Also fixes a test case bug that arose after the isRecording() bug was fixed.