-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump deps to support k8s 1.27 #57
Conversation
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #57 +/- ##
==========================================
+ Coverage 53.96% 54.18% +0.22%
==========================================
Files 1 1
Lines 404 406 +2
==========================================
+ Hits 218 220 +2
Misses 121 121
Partials 65 65
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nice!!! |
in KEDA we use this dep and we have faced with problems due to dep versions. We want to use k8s 0.27 deps, but for using them we need to use sigs.k8s.io/controller-runtime in v0.15.
As this is part of our dependencies, I have bumped dependencies as part of this PR and if you could cut a release with these changes would be nice.
The team from sigs.k8s.io/controller-runtime is waiting till k8s 0.27.2 but they have released an alpha version for enabling the usage before that happens (and that's the version I have used).