Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump deps to support k8s 1.27 #57

Merged
merged 1 commit into from
May 9, 2023

Conversation

JorTurFer
Copy link
Contributor

@JorTurFer JorTurFer commented May 7, 2023

in KEDA we use this dep and we have faced with problems due to dep versions. We want to use k8s 0.27 deps, but for using them we need to use sigs.k8s.io/controller-runtime in v0.15.

As this is part of our dependencies, I have bumped dependencies as part of this PR and if you could cut a release with these changes would be nice.
The team from sigs.k8s.io/controller-runtime is waiting till k8s 0.27.2 but they have released an alpha version for enabling the usage before that happens (and that's the version I have used).

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.22 🎉

Comparison is base (5093eb8) 53.96% compared to head (f33aceb) 54.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   53.96%   54.18%   +0.22%     
==========================================
  Files           1        1              
  Lines         404      406       +2     
==========================================
+ Hits          218      220       +2     
  Misses        121      121              
  Partials       65       65              
Flag Coverage Δ
unittests 54.18% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/rotator/rotator.go 54.18% <100.00%> (+0.22%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit 9d4ef61 into open-policy-agent:master May 9, 2023
@JorTurFer JorTurFer deleted the bump-deps branch May 9, 2023 06:13
@JorTurFer
Copy link
Contributor Author

Nice!!!
One question, will you cut a release soon? I ask for waiting it or using main branch in KEDA (no rush, I can use main branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants