Fix plugins on Windows (#400)

* Fix plugins on Windows

Signed-off-by: John Reese <john@reese.dev>

* Run tidy

Signed-off-by: John Reese <john@reese.dev>

acceptance.bats

@@ -268,13 +268,6 @@
   [[ "$output" =~ "No images tagged latest" ]]
 }
 
-@test "Can download or symlink plugins" {
-  run ./conftest plugin install examples/plugins/kubectl/
-  [ "$status" -eq 0 ]
-  run ./conftest kubectl
-  [ "$status" -eq 0 ]
-}
-
 @test "The number of tests run is accurate" {
   run ./conftest test -p examples/kubernetes/policy examples/kubernetes/service.yaml --no-color
   [ "$status" -eq 0 ]
@@ -314,3 +307,20 @@
   [ "$status" -eq 1 ]
   [[ "$output" =~ "2 tests, 1 passed, 0 warnings, 1 failure" ]]
 }
+
+@test "Can install plugin from directory" {
+  run ./conftest plugin install contrib/plugins/kubectl
+  [ "$status" -eq 0 ]
+
+  run ./conftest kubectl
+  [ "$status" -eq 0 ]
+}
+
+# Uncomment test when the plugin exists on GitHub
+#@test "Can install plugin from URL" {
+#  run ./conftest plugin install github.com/open-policy-agent/conftest/contrib/plugins/kubectl
+#  [ "$status" -eq 0 ]
+#
+#  run ./conftest kubectl
+#  [ "$status" -eq 0 ]
+#}

contrib/plugins/kubectl-conftest.sh → contrib/plugins/kubectl/kubectl-conftest.sh

@@ -4,7 +4,6 @@
 # It uses the conftest utility and expects to find associated policy files in
 # a directory called policy
 
-
 # Check if a specified command exists on the path and is executable
 function check_command () {
     if ! [[ -x $(command -v "$1") ]] ; then
@@ -19,7 +18,7 @@ function usage () {
     echo "See https://github.com/open-policy-agent/conftest for more information"
     echo
     echo "Usage:"
-    echo "   kubectl conftest (TYPE[.VERSION][.GROUP] [NAME] | TYPE[.VERSION][.GROUP]/NAME)"
+    echo "   conftest kubectl (TYPE[.VERSION][.GROUP] [NAME] | TYPE[.VERSION][.GROUP]/NAME)"
 }
 
 # Check the required commands are available on the PATH

internal/commands/default.go

@@ -63,19 +63,17 @@ func NewDefaultCommand() *cobra.Command {
 }
 
 func loadPlugins(ctx context.Context) ([]*cobra.Command, error) {
-	plugins, err := plugin.FindPlugins()
+	plugins, err := plugin.FindAll()
 	if err != nil {
-		return nil, fmt.Errorf("loading plugins: %v", err)
+		return nil, fmt.Errorf("find plugins: %v", err)
 	}
 
 	var cmds []*cobra.Command
 	for _, plugin := range plugins {
-		plugin := plugin
-		metaData := plugin.MetaData
-		cmd := &cobra.Command{
-			Use:   metaData.Name,
-			Short: metaData.Usage,
-			Long:  metaData.Description,
+		cmd := cobra.Command{
+			Use:   plugin.Name,
+			Short: plugin.Usage,
+			Long:  plugin.Description,
 			RunE: func(cmd *cobra.Command, args []string) error {
 				if err := plugin.Exec(ctx, args); err != nil {
 					return fmt.Errorf("execute plugin: %v", err)
@@ -86,7 +84,7 @@ func loadPlugins(ctx context.Context) ([]*cobra.Command, error) {
 			DisableFlagParsing: true,
 		}
 
-		cmds = append(cmds, cmd)
+		cmds = append(cmds, &cmd)
 	}
 
 	return cmds, nil

internal/commands/plugin.go

@@ -10,7 +10,7 @@ import (
 func NewPluginCommand(ctx context.Context) *cobra.Command {
 	cmd := cobra.Command{
 		Use:   "plugin",
-		Short: "manage conftest plugins",
+		Short: "Manage conftest plugins",
 		Long:  "This command manages conftest plugins",
 	}
 

internal/commands/plugin_install.go

@@ -11,10 +11,9 @@ import (
 const installDesc = `
 This command installs a plugin from the given path or url
 
-
 Several locations are supported by the plugin install command. Under the hood
 conftest leverages go-getter (https://github.com/hashicorp/go-getter).
-The  following protocols are supported for downloading plugins:
+The following protocols are supported for downloading plugins:
 
 	- Local Files
 	- Git
@@ -23,9 +22,10 @@ The  following protocols are supported for downloading plugins:
 	- Amazon S3
 	- Google Cloud GCP
 
-The location of the plugins is specified by passing an URL, e.g.:
+The location of the plugins is specified by passing a path or URL, e.g.:
 
-	$ conftest plugin install https://github.com/open-policy-agent/conftest/examples/plugins/kubectl
+	$ conftest plugin install github.com/open-policy-agent/conftest/examples/plugins/kubectl
+	$ conftest plugin install contrib/plugins/kubectl
 
 Based on the protocol a different mechanism will be used to download the plugin.
 The pull command will also try to infer the protocol based on the URL if the
@@ -43,8 +43,8 @@ func NewPluginInstallCommand(ctx context.Context) *cobra.Command {
 		Args:  cobra.MinimumNArgs(1),
 
 		RunE: func(cmd *cobra.Command, args []string) error {
-			if err := plugin.Download(ctx, args[0]); err != nil {
-				return fmt.Errorf("install plugin: %v", err)
+			if err := plugin.Install(ctx, args[0]); err != nil {
+				return fmt.Errorf("install: %v", err)
 			}
 
 			return nil