Allow structured errors in rules#243
Merged
Merged
Conversation
Closed
Member
|
@jpreese overall looks good |
Member
Author
|
@boranx once approved we can click the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based heavily off of the work done by @gwkunze in #100. Master has diverged quite a bit since the original discussions and PRs, so the important bits were cherrypicked from there.
This PR enables
regorules to use structured errors in their rulese.g.
warn[msg] { kubernetes.is_service msg = sprintf("Found service %s but services are not allowed", [name]) }could now be
violation[{"msg": msg, "details":{"additional": "extra stuff here if wanted"}}] { kubernetes.is_service msg = sprintf("Found service %s but services are not allowed", [name]) }This will enable us to support Gatekeeper policies that require a rule header of
violation[{"msg": msg, "details":{}}]