feat: improve combined input example #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs example policy for the `combine` flag uses underscores for the index of the input document The underscore should be avoided here, as it can lead to data being resolved in multiple input documents where the policy calls for acting on a single document in a set Signed-off-by: Stewart Platt <shteou@gmail.com>
|
Makes sense to me, thanks for your contribution @shteou ! |
jpreese
approved these changes
Apr 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs example policy for the
combineflag uses underscoresfor the index of the input document
The underscore should be avoided here, as it can lead to data
being resolved in multiple input documents where the policy calls
for acting on a single document in a set
Signed-off-by: Stewart Platt shteou@gmail.com