Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add externaldata v1beta1 api #270

Merged
merged 13 commits into from
Dec 14, 2022
Merged

feat: add externaldata v1beta1 api #270

merged 13 commits into from
Dec 14, 2022

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Dec 7, 2022 •
edited

Signed-off-by: Sertac Ozercan sozercan@gmail.com

GK PR: open-policy-agent/gatekeeper#2438

@sozercan
remove docker it
991fe59 
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan
add v1beta1
7eb3b1f 
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan
fix lint
e3581be 
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan
conversion
faa5bac 
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan
update dependencies
020ccff 
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan sozercan force-pushed the externaldata-v1beta1 branch 2 times, most recently from b82f91d to f4198ff Compare December 7, 2022 22:06
@sozercan
autoconvert
86cbcbc 
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan
update
6bbb1d3 
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2022 •
edited

Codecov Report

Base: 50.39% // Head: 49.30% // Decreases project coverage by -1.09% ⚠️

Coverage data is based on head (ffb1219) compared to base (1c9ce4f).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
- Coverage   50.39%   49.30%   -1.10%     
==========================================
  Files          64       69       +5     
  Lines        4274     4468     +194     
==========================================
+ Hits         2154     2203      +49     
- Misses       1881     2021     +140     
- Partials      239      244       +5
Flag Coverage Δ
unittests 49.30% <ø> (-1.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nt/frameworks/constraint/pkg/externaldata/cache.go 95.94% <0.00%> (-0.40%) ⬇️
...int/pkg/apis/templates/v1/zz_generated.deepcopy.go 31.51% <0.00%> (ø)
...int/pkg/apis/templates/v1/zz_generated.defaults.go 45.45% <0.00%> (ø)
...t/pkg/apis/externaldata/v1alpha1/provider_types.go 100.00% <0.00%> (ø)
...kg/apis/templates/v1beta1/zz_generated.deepcopy.go 31.51% <0.00%> (ø)
...kg/apis/templates/v1beta1/zz_generated.defaults.go 45.45% <0.00%> (ø)
...g/apis/templates/v1alpha1/zz_generated.deepcopy.go 31.51% <0.00%> (ø)
...g/apis/templates/v1alpha1/zz_generated.defaults.go 45.45% <0.00%> (ø)
...nt/pkg/apis/externaldata/v1beta1/provider_types.go 100.00% <0.00%> (ø)
...is/externaldata/v1beta1/zz_generated.conversion.go 2.63% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sozercan
add deprecation msg
0b5099a 
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan sozercan mentioned this pull request Dec 8, 2022
Merged
maxsmythe
maxsmythe reviewed Dec 8, 2022
View reviewed changes
constraint/config/crds/externaldata.gatekeeper.sh_providers.yaml Outdated Show resolved Hide resolved
constraint/pkg/externaldata/cache.go Outdated Show resolved Hide resolved
constraint/pkg/externaldata/request.go Outdated Show resolved Hide resolved
@sozercan
unversioned api
82c9b73 
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan
update unversioned
5c99019 
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan
remove tls skip flag
5318d13 
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
maxsmythe
maxsmythe approved these changes Dec 10, 2022
View reviewed changes
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sozercan sozercan mentioned this pull request Dec 12, 2022
Closed
@ritazh
Copy link
Member

ritazh commented Dec 12, 2022

Why is gatekeeper_test broken?

@sozercan
Copy link
Member Author

sozercan commented Dec 12, 2022 •
edited

Why is gatekeeper_test broken?

Supposed to be broken (it's a signal, not a pr gate). open-policy-agent/gatekeeper#2438 addresses those

@sozercan
update remove test to https
deba335 
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan sozercan mentioned this pull request Dec 13, 2022
Closed
@sozercan
Copy link
Member Author

@ritazh good to merge?

ritazh
ritazh approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit b745745 into open-policy-agent:master Dec 14, 2022
@sozercan sozercan deleted the externaldata-v1beta1 branch December 14, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsmythe maxsmythe maxsmythe approved these changes

@enj enj enj left review comments

@ritazh ritazh ritazh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sozercan @codecov-commenter @ritazh @maxsmythe @enj