-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump externaldata v1beta1 api #2438
chore: bump externaldata v1beta1 api #2438
Conversation
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
7ca2c58
to
430e86e
Compare
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
430e86e
to
54fd6b0
Compare
Codecov ReportBase: 53.68% // Head: 53.63% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2438 +/- ##
==========================================
- Coverage 53.68% 53.63% -0.05%
==========================================
Files 117 117
Lines 10292 10303 +11
==========================================
+ Hits 5525 5526 +1
- Misses 4346 4353 +7
- Partials 421 424 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ed31f16
to
ded8deb
Compare
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
ded8deb
to
0a95b74
Compare
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
f98983e
to
7225944
Compare
4d7218a
to
b73e79a
Compare
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
3f5aa2a
to
14a89bb
Compare
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
8514c84
to
7517cb2
Compare
@maxsmythe still working on helm upgrade test but rest is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming the helm upgrade test doesn't require any novel code
9626eb5
to
1684a27
Compare
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
1684a27
to
e4a130b
Compare
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@maxsmythe Fixed the issue with the helm upgrade. However, we had to bump the helm upgrade base version from 3.5 to 3.9 and we have to have external data enabled. Otherwise, GK certificate does not get generated with Line 202 in 3869b0e
|
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Let's make sure to add this to the external data mtls doc (maybe a followup PR). |
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
… into externaldata-v1beta1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Alex Pana 8968914+acpana@users.noreply.github.comWhat this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #2434 #2454
Special notes for your reviewer:
vendoring in open-policy-agent/frameworks#270
based on #2436, will rebase once it merges