errors.As instead of type casting in unit tests

\nSigned-off-by: davis-haba <davishaba@google.com>
open-policy-agent · Jan 21, 2023 · 61da4ed · 61da4ed
1 parent c269326
commit 61da4ed
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/pkg/mutation/mutators/assignimage/assignimage_mutator_test.go b/pkg/mutation/mutators/assignimage/assignimage_mutator_test.go
@@ -332,8 +332,8 @@ func TestMutatorForAssignImage(t *testing.T) {
 				applyTo:  []match.ApplyTo{{Groups: []string{""}, Versions: []string{"v1"}, Kinds: []string{"Foo"}}},
 			},
 			errFn: func(err error) bool {
-				_, ok := err.(metadataRootError)
-				return ok
+				var tarErr *metadataRootError
+				return errors.As(err, &tarErr)
 			},
 		},
 		{
@@ -346,8 +346,8 @@ func TestMutatorForAssignImage(t *testing.T) {
 				applyTo:  []match.ApplyTo{{Groups: []string{""}, Versions: []string{"v1"}, Kinds: []string{"Foo"}}},
 			},
 			errFn: func(err error) bool {
-				_, ok := err.(listTerminalError)
-				return ok
+				var tarErr *listTerminalError
+				return errors.As(err, &tarErr)
 			},
 		},
 		{
@@ -373,8 +373,8 @@ func TestMutatorForAssignImage(t *testing.T) {
 				applyTo:  []match.ApplyTo{{Groups: []string{""}, Versions: []string{"v1"}, Kinds: []string{"Foo"}}},
 			},
 			errFn: func(err error) bool {
-				_, ok := errors.Unwrap(err).(domainLikePathError)
-				return ok
+				var tarErr *domainLikePathError
+				return errors.As(err, &tarErr)
 			},
 		},
 	}