Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add second check if watchmanager started #118

Merged

Conversation

ctab
Copy link
Member

@ctab ctab commented May 22, 2019

Another wm.started check needed so that watch manager can eventually restart. Gets stuck in a stopped state forever otherwise.

Signed-off-by: Craig Tabita ctab@google.com

Signed-off-by: Craig Tabita <ctab@google.com>
@ctab ctab requested a review from maxsmythe May 22, 2019 13:34
pkg/watch/manager.go Outdated Show resolved Hide resolved
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. 1 test to update, one comment to tweak.

pkg/watch/manager.go Show resolved Hide resolved
ctab added 3 commits May 29, 2019 06:50
Signed-off-by: Craig Tabita <ctab@google.com>
Signed-off-by: Craig Tabita <ctab@google.com>
Signed-off-by: Craig Tabita <ctab@google.com>
@ctab ctab force-pushed the watch-manager-check-if-started branch from 3969794 to 60d9ab7 Compare June 3, 2019 19:33
ctab and others added 9 commits June 3, 2019 15:29
Signed-off-by: Craig Tabita <ctab@google.com>
Signed-off-by: Craig Tabita <ctab@google.com>
Signed-off-by: Craig Tabita <ctab@google.com>
Signed-off-by: Craig Tabita <ctab@google.com>
Signed-off-by: Craig Tabita <ctab@google.com>
Signed-off-by: Craig Tabita <ctab@google.com>
Signed-off-by: Craig Tabita <ctab@google.com>
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxsmythe maxsmythe merged commit 7faaf6b into open-policy-agent:master Jun 4, 2019
@ctab ctab deleted the watch-manager-check-if-started branch June 12, 2019 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants