Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crd errors oscillation #134

Merged
merged 2 commits into from
Jun 12, 2019
Merged

Crd errors oscillation #134

merged 2 commits into from
Jun 12, 2019

Conversation

ctab
Copy link
Member

@ctab ctab commented Jun 12, 2019

No description provided.

ctab added 2 commits June 12, 2019 15:14
@ctab
move crd update to prevent oscillating errors state
58d182f 
Signed-off-by: Craig Tabita <ctab@google.com>
@ctab
cleanup
ce04a1a 
Signed-off-by: Craig Tabita <ctab@google.com>
@ctab ctab requested a review from maxsmythe June 12, 2019 23:00
maxsmythe
maxsmythe approved these changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxsmythe maxsmythe merged commit 907d1f0 into open-policy-agent:master Jun 12, 2019
@ctab ctab deleted the crd_errors_oscillation branch June 12, 2019 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsmythe maxsmythe maxsmythe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ctab @maxsmythe