Remove non-specific webhook request metrics #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As g8r once had only a validation webhook, certain metrics (request_count, request_count_duration_seconds) were implemented without qualifiers. i.e., the fact that they applied to the validation webhook was _assumed_. As g8r now has both validation and mutation webhooks, separate metrics for both are required. These metrics have already been implemented, and have been released since v3.4.0. The original metrics were deprecated (but retained) at the time of that release. As we are approaching v3.6, it is finally time to remove these metrics. This PR removes the code and updates the metrics README. Fixes open-policy-agent#1010 Signed-off-by: juliankatz <juliankatz@google.com>
Codecov Report
@@ Coverage Diff @@
## master #1428 +/- ##
==========================================
- Coverage 50.04% 49.99% -0.06%
==========================================
Files 75 75
Lines 5061 5047 -14
==========================================
- Hits 2533 2523 -10
+ Misses 2178 2175 -3
+ Partials 350 349 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
… deprecate-non-specific-metrics Signed-off-by: juliankatz <juliankatz@google.com>
sozercan
reviewed
Jul 8, 2021
… deprecate-non-specific-metrics Signed-off-by: juliankatz <juliankatz@google.com>
… deprecate-non-specific-metrics Signed-off-by: juliankatz <juliankatz@google.com>
julianKatz
added a commit
to julianKatz/gatekeeper
that referenced
this pull request
Jul 27, 2021
As g8r once had only a validation webhook, certain metrics (request_count, request_count_duration_seconds) were implemented without qualifiers. i.e., the fact that they applied to the validation webhook was _assumed_. As g8r now has both validation and mutation webhooks, separate metrics for both are required. These metrics have already been implemented, and have been released since v3.4.0. The original metrics were deprecated (but retained) at the time of that release. As we are approaching v3.6, it is finally time to remove these metrics. This PR removes the code and updates the metrics README. Fixes open-policy-agent#1010 Signed-off-by: juliankatz <juliankatz@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As g8r once had only a validation webhook, certain metrics
(request_count, request_count_duration_seconds) were implemented without
qualifiers. i.e., the fact that they applied to the validation webhook
was assumed.
As g8r now has both validation and mutation webhooks, separate metrics
for both are required. These metrics have already been implemented, and
have been released since v3.4.0. The original metrics were deprecated
(but retained) at the time of that release.
As we are approaching v3.6, it is finally time to remove these metrics.
This PR removes the code and updates the metrics README.
Fixes #1010
Signed-off-by: juliankatz juliankatz@google.com