Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-specific webhook request metrics #1428

Merged

Commits on Jul 8, 2021

  1. Remove non-specific webhook request metrics

    As g8r once had only a validation webhook, certain metrics
    (request_count, request_count_duration_seconds) were implemented without
    qualifiers.  i.e., the fact that they applied to the validation webhook
    was _assumed_.
    
    As g8r now has both validation and mutation webhooks, separate metrics
    for both are required.  These metrics have already been implemented, and
    have been released since v3.4.0.  The original metrics were deprecated
    (but retained) at the time of that release.
    
    As we are approaching v3.6, it is finally time to remove these metrics.
    This PR removes the code and updates the metrics README.
    
    Fixes open-policy-agent#1010
    
    Signed-off-by: juliankatz <juliankatz@google.com>
    julianKatz committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    5af16dc View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' of github.com:open-policy-agent/gatekeeper into…

    … deprecate-non-specific-metrics
    
    Signed-off-by: juliankatz <juliankatz@google.com>
    julianKatz committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    605f1a8 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2021

  1. Merge branch 'master' of github.com:open-policy-agent/gatekeeper into…

    … deprecate-non-specific-metrics
    
    Signed-off-by: juliankatz <juliankatz@google.com>
    julianKatz committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    0bb9b3f View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' of github.com:open-policy-agent/gatekeeper into…

    … deprecate-non-specific-metrics
    
    Signed-off-by: juliankatz <juliankatz@google.com>
    julianKatz committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    ba73714 View commit details
    Browse the repository at this point in the history