New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): Allow setting annotations for mutating and validating webhook configurations #2231
feat(helm): Allow setting annotations for mutating and validating webhook configurations #2231
Conversation
Signed-off-by: Ethan Range <65268454+ethanrange@users.noreply.github.com>
Signed-off-by: Ethan Range <65268454+ethanrange@users.noreply.github.com>
Signed-off-by: Ethan Range <65268454+ethanrange@users.noreply.github.com>
Signed-off-by: Ethan Range <65268454+ethanrange@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #2231 +/- ##
==========================================
+ Coverage 54.33% 54.43% +0.10%
==========================================
Files 111 111
Lines 9538 9538
==========================================
+ Hits 5182 5192 +10
+ Misses 3956 3949 -7
+ Partials 400 397 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hi, if anyone has a chance to review this that'd be great. Thanks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged): This PR allows for the annotations for theMutatingWebhookConfiguration
andValidatingWebhookConfiguration
to be set through the chart. Allows for certificate injection withcert-manager
(See https://cert-manager.io/docs/concepts/ca-injector/)Special notes for your reviewer:
N/A