New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Expose options to allow injection of external certificates #2249
feat: Expose options to allow injection of external certificates #2249
Conversation
* Allow overriding the certificate secret name * Only generate cert-secret if external injection is disabled * Disable default certificate rotation when injecting Signed-off-by: Ethan Range <65268454+ethanrange@users.noreply.github.com>
Signed-off-by: Ethan Range <65268454+ethanrange@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #2249 +/- ##
==========================================
- Coverage 54.57% 54.39% -0.18%
==========================================
Files 111 111
Lines 9554 9554
==========================================
- Hits 5214 5197 -17
- Misses 3946 3958 +12
- Partials 394 399 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hi, I'm away for a while from next week onwards - if someone has a chance to review this before the weekend that'd be great - I can then make any changes requested before I leave. No worries if not, I can handle it upon my return. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit, but otherwise lgtm
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Ethan Range <65268454+ethanrange@users.noreply.github.com>
Signed-off-by: Ethan Range <65268454+ethanrange@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
This PR is very similar to #1359 by @romachalm which was unfortunately never merged as the author stopped responding. I had followed the same path, implementing webhook annotations in #2231 before stumbling across this PR. I have recreated this with a slightly different interface.
This PR allows for external certificates to be injected and used in place of the default, self signed certificate. This is useful when using services such as
cert-manager
to automatically sign and rotate certificates. It provides Helm chart config values which when set:This, in combination with the annotations in #2231 allows for configuring external certificate injection
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #520
Special notes for your reviewer:
N/A