Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make target-template-source to build pkg/target/target_template_source.go #257

Merged
merged 8 commits into from
Oct 12, 2019

Conversation

ctab
Copy link
Member

@ctab ctab commented Oct 4, 2019

We had duplicated rego in a rego.src and hard coded in a .go file (although there were already a couple divergences). I added a make target to generate a go file from the rego.src.

Signed-off-by: Craig Tabita ctab@google.com

…ource.go

Signed-off-by: Craig Tabita <ctab@google.com>
Signed-off-by: Craig Tabita <ctab@google.com>
Signed-off-by: Craig Tabita <ctab@google.com>
@ctab ctab requested a review from maxsmythe October 4, 2019 00:45
Signed-off-by: Craig Tabita <ctab@google.com>
Signed-off-by: Craig Tabita <ctab@google.com>
Signed-off-by: Craig Tabita <ctab@google.com>
Makefile Show resolved Hide resolved
Signed-off-by: Craig Tabita <ctab@google.com>
Signed-off-by: Craig Tabita <ctab@google.com>
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxsmythe maxsmythe merged commit 9c1b889 into open-policy-agent:master Oct 12, 2019
@ctab ctab deleted the target_duplicate_rego branch October 14, 2019 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants