Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase cpu limits #309

Merged
merged 2 commits into from
Nov 27, 2019
Merged

increase cpu limits #309

merged 2 commits into from
Nov 27, 2019

Conversation

zoetrope
Copy link
Contributor

fix #266

@zoetrope
increase cpu limits
6f73c23 
Signed-off-by: zoetrope <a.ikezoe@gmail.com>
@zoetrope
Copy link
Contributor Author

I signed it

@zoetrope
Copy link
Contributor Author

ref. https://cloud.google.com/blog/products/gcp/kubernetes-best-practices-resource-requests-and-limits

Unless your app is specifically designed to take advantage of multiple cores (scientific computing and some databases come to mind), it is usually a best practice to keep the CPU request at ‘1’ or below, and run more replicas to scale it out. This gives the system more flexibility and reliability.

maxsmythe
maxsmythe requested changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for this!

Could you change the limit here as well so it doesn't get clobbered the next time the manifest is autogenned?

gatekeeper/config/manager/manager.yaml

Line 46 in 2607bbe

cpu: 100m

@zoetrope
increase cpu limits
296d850 
Signed-off-by: zoetrope <a.ikezoe@gmail.com>
@zoetrope
Copy link
Contributor Author

Thank you for your review.
I fixed it.

maxsmythe
maxsmythe approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@maxsmythe maxsmythe merged commit 7514bcc into open-policy-agent:master Nov 27, 2019
@maxsmythe maxsmythe mentioned this pull request Mar 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsmythe maxsmythe maxsmythe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Performance issue] validatingwebhookconfiguration too slow
2 participants
@zoetrope @maxsmythe