Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #3146 Support close open/fail for Ready Tracker & surface errors swallowed by grp.Wait() #3308

Merged

Commits on Jul 2, 2024

  1. Add error handling & fail-close support in Ready Tracker

    Add fail-close support for fetching expectations by adding error handling & surfacing the errors being swallowed by grp.Wait().
    
    Signed-off-by: David-Jaeyoon-Lee <davjlee@google.com>
    David-Jaeyoon-Lee committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    78d01f8 View commit details
    Browse the repository at this point in the history
  2. Fix starting flag with hyphen

    Remove the starting hyphen from the
    crash-on-failure-fetching-expectations flag
    
    Signed-off-by: David-Jaeyoon-Lee <davjlee@google.com>
    David-Jaeyoon-Lee committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    1917366 View commit details
    Browse the repository at this point in the history
  3. Add comment for constraint & data tracker, fix retErr nil comparison,

    and add unit tests
    Fix comments and return error in trackConfigAndSyncSets. Add unit tests
    for each track method & each wait in Run method.
    
    Signed-off-by: David-Jaeyoon-Lee <davjlee@google.com>
    David-Jaeyoon-Lee committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    af869f0 View commit details
    Browse the repository at this point in the history
  4. Fix crashOnFailureFetchingExpectations flag description & race condition

    in test
    
    Signed-off-by: David-Jaeyoon-Lee <davjlee@google.com>
    David-Jaeyoon-Lee committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    5010682 View commit details
    Browse the repository at this point in the history
  5. Remove Errgroup logic from ReadyTracker

    Change errgroup logic such that we instead use waitgroups and errchannels.
    This is that we remove the idea of shared fate between each
    tracking/subtracking threads. Removes complexity of figuring out what the
    errgroups are doing as well as complicated logic with shared fate between
    tracking threads and singlerunners
    
    Signed-off-by: David-Jaeyoon-Lee <davjlee@google.com>
    David-Jaeyoon-Lee committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    876b50a View commit details
    Browse the repository at this point in the history
  6. Removing race condition by giving each fake client its own scheme object

    Signed-off-by: David-Jaeyoon-Lee <davjlee@google.com>
    David-Jaeyoon-Lee committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    f874270 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Change naming of variables, refactor, and lint errors

    Signed-off-by: David-Jaeyoon-Lee <davjlee@google.com>
    David-Jaeyoon-Lee committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    212d84c View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Configuration menu
    Copy the full SHA
    b1a8531 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Configuration menu
    Copy the full SHA
    762134e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bf49b3c View commit details
    Browse the repository at this point in the history