Remove the sync finalizer #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkleeman
force-pushed
the
remove-sync-finalizer
branch
4 times, most recently
from
945e2df
to
39ba9db
Compare
Fixes open-policy-agent#352. Removes the sync finalizer on objects that have been cached, and the various bits of logic around keeping track of what objects have finalizers and removing them on shutdown etc. Signed-off-by: Jack Kleeman <jackkleeman@gmail.com>
jackkleeman
force-pushed
the
remove-sync-finalizer
branch
from
39ba9db
to
bc2ad08
Compare
maxsmythe
requested changes
Dec 24, 2019
| @@ -153,7 +156,6 @@ func (r *ReconcileConfig) Reconcile(request reconcile.Request) (reconcile.Result | |||
| } | |||
|
|
|||
| newSyncOnly := newSet() | |||
| toClean := newSet() | |||
| if instance.GetDeletionTimestamp().IsZero() { | |||
| if !hasFinalizer(instance) { | |||
| instance.SetFinalizers(append(instance.GetFinalizers(), finalizerName)) | |||
There was a problem hiding this comment.
We can remove this finalizer too. Let's leave that for a follow-on PR in the interest of incremental changes.
jackkleeman
force-pushed
the
remove-sync-finalizer
branch
3 times, most recently
from
1c2eed6
to
307e5b5
Compare
Signed-off-by: Jack Kleeman <jackkleeman@gmail.com>
jackkleeman
force-pushed
the
remove-sync-finalizer
branch
from
307e5b5
to
25c6fa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #352. Removes the sync finalizer on objects that have been cached,
and the various bits of logic around keeping track of what objects have
finalizers and removing them on shutdown etc.