Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the sync finalizer #369

Merged
merged 2 commits into from Dec 30, 2019
Merged

Remove the sync finalizer #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc2ad08
Remove the sync finalizer
jackkleeman Dec 23, 2019
25c6fa6
Add test for namespace sync
jackkleeman Dec 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 0 additions & 19 deletions api/v1alpha1/config_types.go
View file
Open in desktop
Expand Up @@ -17,7 +17,6 @@ package v1alpha1

import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime/schema"
)

// ConfigSpec defines the desired state of Config
Expand Down Expand Up @@ -56,27 +55,9 @@ type SyncOnlyEntry struct {
Kind string `json:"kind,omitempty"`
}

type ByPod struct {
// a unique identifier for the pod that wrote the status
ID string `json:"id,omitempty"`
// List of Group/Version/Kinds with finalizers
AllFinalizers []GVK `json:"allFinalizers,omitempty"`
}

// ConfigStatus defines the observed state of Config
type ConfigStatus struct {
// Important: Run "make" to regenerate code after modifying this file

// List of statuses as seen by individual pods
ByPod []*ByPod `json:"byPod,omitempty"`
}

func ToAPIGVK(gvk schema.GroupVersionKind) GVK {
return GVK{Group: gvk.Group, Version: gvk.Version, Kind: gvk.Kind}
}

func ToGVK(gvk GVK) schema.GroupVersionKind {
return schema.GroupVersionKind{Group: gvk.Group, Version: gvk.Version, Kind: gvk.Kind}
}

type GVK struct {
Expand Down
33 changes: 1 addition & 32 deletions api/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 1 addition & 23 deletions config/crd/bases/config.gatekeeper.sh_configs.yaml
View file
Open in desktop
Expand Up @@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.2.2
controller-gen.kubebuilder.io/version: v0.2.4
creationTimestamp: null
name: configs.config.gatekeeper.sh
spec:
Expand Down Expand Up @@ -82,28 +82,6 @@ spec:
type: object
status:
description: ConfigStatus defines the observed state of Config
properties:
byPod:
description: List of statuses as seen by individual pods
items:
properties:
allFinalizers:
description: List of Group/Version/Kinds with finalizers
items:
properties:
group:
type: string
kind:
type: string
version:
type: string
type: object
type: array
id:
description: a unique identifier for the pod that wrote the status
type: string
type: object
type: array
type: object
type: object
version: v1alpha1
Expand Down
24 changes: 1 addition & 23 deletions deploy/gatekeeper.yaml
View file
Open in desktop
Expand Up @@ -9,7 +9,7 @@ apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.2.2
controller-gen.kubebuilder.io/version: v0.2.4
creationTimestamp: null
name: configs.config.gatekeeper.sh
spec:
Expand Down Expand Up @@ -87,28 +87,6 @@ spec:
type: object
status:
description: ConfigStatus defines the observed state of Config
properties:
byPod:
description: List of statuses as seen by individual pods
items:
properties:
allFinalizers:
description: List of Group/Version/Kinds with finalizers
items:
properties:
group:
type: string
kind:
type: string
version:
type: string
type: object
type: array
id:
description: a unique identifier for the pod that wrote the status
type: string
type: object
type: array
type: object
type: object
version: v1alpha1
Expand Down