Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make constraint targets KRM conventions-compliant #83

Merged
merged 3 commits into from Apr 7, 2019

Conversation

Projects
None yet
2 participants
@maxsmythe
Copy link
Contributor

commented Apr 6, 2019

Switches to using a list of targets rather than a map to comply with KRM conventions. Thank you to ritazh@ for bringing this doc to my attention.

Also adds in the vendor/ directory to help avoid stale dependency issues.

The two changes are separated by different commits.

@maxsmythe maxsmythe requested review from tsandall and ritazh Apr 6, 2019

@tsandall
Copy link
Member

left a comment

LGTM

maxsmythe added some commits Apr 6, 2019

Make constraint targets KRM conventions-compliant
Signed-off-by: Max Smythe <smythe@google.com>
Include the vendor directory
A look at the licenses of the projects shows the following:

  * Apache License
  * ISC License
  * Mozilla Public License
  * MIT
  * BSD

Signed-off-by: Max Smythe <smythe@google.com>
Fix kubectl apply error in deploy Makefile rule
Signed-off-by: Max Smythe <smythe@google.com>

@maxsmythe maxsmythe force-pushed the maxsmythe:krm_compliance branch from 0c696d3 to 68fe199 Apr 7, 2019

@maxsmythe maxsmythe merged commit 434244b into open-policy-agent:master Apr 7, 2019

3 checks passed

DCO DCO
Details
cla/linuxfoundation maxsmythe authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxsmythe maxsmythe deleted the maxsmythe:krm_compliance branch Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.