Fix set-env deprecation #969
Conversation
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #969 +/- ##
==========================================
- Coverage 43.60% 43.54% -0.07%
==========================================
Files 52 52
Lines 3222 3222
==========================================
- Hits 1405 1403 -2
Misses 1622 1622
- Partials 195 197 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -199,7 +199,8 @@ jobs: | |||
| make e2e-verify-release IMG=${{ env.IMAGE_REPO }}:${TAG} USE_LOCAL_IMG=false | |||
|
|
|||
| - name: Create GitHub release | |||
| uses: "marvinpinto/action-automatic-releases@v1.1.0" | |||
| # using latest to fix set-env deprecation | |||
| uses: "marvinpinto/action-automatic-releases@latest" | |||
There was a problem hiding this comment.
Do we want to be using latest here? Is there a version we should be pinning to to avoid spontaneous breakage?
There was a problem hiding this comment.
unfortunately, not yet. https://github.com/marvinpinto/action-automatic-releases/releases
we'll want to pin it once it's available.
There was a problem hiding this comment.
Ah well, thanks for clarifying!
…agent#969-upstream-release-3.1
Signed-off-by: Sertac Ozercan sozercan@gmail.com
What this PR does / why we need it:
We had a leftover of using
set-envin our CI and release action also usesset-envinternally (which is fixed inlatest).Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: