Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix set-env deprecation #969

Merged
merged 2 commits into from Nov 18, 2020
Merged

Fix set-env deprecation #969

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18a0855
fix set-env deprecation
sozercan Nov 17, 2020
ae48038
Merge branch 'master' into fix-deprecated-setenv
sozercan Nov 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/workflow.yaml
View file
Open in desktop
Expand Up @@ -168,7 +168,7 @@ jobs:
- name: Get tag
id: get_version
run: |
echo ::set-env name=TAG::${GITHUB_REF#refs/tags/}
echo "TAG=${GITHUB_REF#refs/tags/}" >> $GITHUB_ENV
echo $TAG

- name: Publish release
Expand Down Expand Up @@ -199,7 +199,8 @@ jobs:
make e2e-verify-release IMG=${{ env.IMAGE_REPO }}:${TAG} USE_LOCAL_IMG=false

- name: Create GitHub release
uses: "marvinpinto/action-automatic-releases@v1.1.0"
# using latest to fix set-env deprecation
uses: "marvinpinto/action-automatic-releases@latest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to be using latest here? Is there a version we should be pinning to to avoid spontaneous breakage?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately, not yet. https://github.com/marvinpinto/action-automatic-releases/releases
we'll want to pin it once it's available.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah well, thanks for clarifying!

with:
repo_token: "${{ secrets.GITHUB_TOKEN }}"
prerelease: false
Expand Down